Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PUT metadata endpoint #51

Merged
merged 10 commits into from
Apr 4, 2023
Merged

Add PUT metadata endpoint #51

merged 10 commits into from
Apr 4, 2023

Conversation

vmilitaru
Copy link
Contributor

What

  • add new PUT metadata endpoint which updates only a given list of editable metadata fields by making a single call to the new putMetadata endpoint from the dp-dataset-api ONSdigital/dp-dataset-api#415
  • updates the GetMetadataHandler to use the new GetVersionWithHeaders dataset client method, so that florence could access the versionEtag ==> see ONSdigital/dp-api-clients-go#411
  • adds a put metadata mapper which returns a list of editable metadata fields
  • adds VersionEtag field to the EditMetadata structure

How to review

  • check the code and make sure the tests passes

Who can review

anyone

@vmilitaru vmilitaru mentioned this pull request Mar 31, 2023
Merged
cookel2
cookel2 reviewed Mar 31, 2023
View reviewed changes
dataset/put-metadata.go Outdated Show resolved Hide resolved
cookel2
cookel2 reviewed Mar 31, 2023
View reviewed changes
dataset/put-metadata.go Outdated Show resolved Hide resolved
cookel2
cookel2 reviewed Mar 31, 2023
View reviewed changes
dataset/put-metadata.go Outdated Show resolved Hide resolved
cookel2
cookel2 reviewed Mar 31, 2023
View reviewed changes
dataset/put-metadata.go Outdated Show resolved Hide resolved
cookel2
cookel2 requested changes Mar 31, 2023
View reviewed changes
Copy link

@cookel2 cookel2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small comments @vmilitaru

@vmilitaru vmilitaru requested a review from cookel2 March 31, 2023 14:58
cookel2
cookel2 approved these changes Apr 3, 2023
View reviewed changes
Copy link

@cookel2 cookel2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@rafahop rafahop merged commit 3df247b into develop Apr 4, 2023
@rafahop rafahop deleted the feature/add-put-metadata-endpoint branch April 4, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cookel2 cookel2 cookel2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmilitaru @cookel2 @rafahop